Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: fix select for update statement can't get stmt-count-limit error (#48412) #48467

Merged
merged 3 commits into from
Nov 23, 2023
Merged

session: fix select for update statement can't get stmt-count-limit error (#48412) #48467

merged 3 commits into from
Nov 23, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48412

What problem does this PR solve?

Issue Number: close #48411

Problem Summary: fix select for update statement can't got stmt-count-limit error

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix issue of select for update statement can't get stmt-count-limit error

@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#48412
5bd175a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 21, 2023
@crazycs520
Revert "This is an automated cherry-pick of pingcap#48412"
e658951 
This reverts commit 5bd175a.

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 23, 2023
@crazycs520
session: fix select for update statement can't get stmt-count-limit e…
bb5f1e5 
…rror (pingcap#48412)

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 23, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 23, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ekexium,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 23, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 08:50:03.267138892 +0000 UTC m=+480631.932365087: ☑️ agreed by tiancaiamao.
  • 2023-11-23 08:53:07.153126126 +0000 UTC m=+480815.818352371: ☑️ agreed by ekexium.

@crazycs520
Copy link
Contributor

/retest-required

3 similar comments
@crazycs520
Copy link
Contributor

/retest-required

@crazycs520
Copy link
Contributor

/retest-required

@crazycs520
Copy link
Contributor

/retest-required

@crazycs520
Copy link
Contributor

/retest-required

3 similar comments
@crazycs520
Copy link
Contributor

/retest-required

@crazycs520
Copy link
Contributor

/retest-required

@crazycs520
Copy link
Contributor

/retest-required

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5a6c8c8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #48467   +/-   ##
================================================
  Coverage               ?   73.6561%           
================================================
  Files                  ?       1086           
  Lines                  ?     349132           
  Branches               ?          0           
================================================
  Hits                   ?     257157           
  Misses                 ?      75479           
  Partials               ?      16496

@ti-chi-bot ti-chi-bot bot merged commit bfd8c74 into pingcap:release-6.5 Nov 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees

@crazycs520 crazycs520

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @crazycs520 @tiancaiamao @ekexium